Add Process::ExitReason and Process::Status#exit_reason
#13052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
platform:windows
Comment on lines
+297
to
+322
| private def exit_message(status) | ||
| case status.exit_reason | ||
| when .aborted? | ||
| if status.signal_exit? | ||
| signal = status.exit_signal | ||
| if signal.kill? | ||
| "Program was killed" | ||
| else | ||
| "Program received and didn't handle signal #{signal} (#{signal.value})" | ||
| end | ||
| else | ||
| STDERR.puts "Program received and didn't handle signal #{signal} (#{signal.value})" | ||
| "Program exited abnormally" | ||
| end | ||
| else | ||
| STDERR.puts "Program exited abnormally, the cause is unknown" | ||
| when .breakpoint? | ||
| "Program hit a breakpoint and no debugger was attached" | ||
| when .access_violation?, .bad_memory_access? | ||
| # NOTE: this only happens with the empty prelude, because the stdlib | ||
| # runtime catches those exceptions and then exits _normally_ with exit | ||
| # code 11 or 1 | ||
| "Program exited because of an invalid memory access" | ||
| when .bad_instruction? | ||
| "Program exited because of an invalid instruction" | ||
| when .float_exception? | ||
| "Program exited because of a floating-point system exception" | ||
| when .unknown? | ||
| "Program exited abnormally, the cause is unknown" |
There was a problem hiding this comment.
I'm wondering if this couldn't be useful on its own and moved into Process::Status#description or similar?
This doesn't need to happen in this PR.
straight-shoota
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12284.
As of this PR the compiler itself should no longer depend on
Signaldirectly.