Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graceful parameter to Process#terminate #13070

Conversation

HertzDevil
Copy link
Contributor

This acts as the preferred platform-independent API to send SIGTERM or SIGKILL to a process. See #7339 (comment).

On Windows an exit status must also be supplied; 1 is chosen, as that value is consistent with taskkill /f or the equivalent action in Task Manager.

@straight-shoota straight-shoota added this to the 1.8.0 milestone Feb 13, 2023
@straight-shoota straight-shoota merged commit b07834d into crystal-lang:master Feb 14, 2023
@HertzDevil HertzDevil deleted the feature/process-terminate-graceful branch February 15, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants