Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer matching llvm-config in find-llvm-config #13087

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Feb 18, 2023

Even if the command llvm-config exists and its version matches, any other llvm-config* command with the same version would currently be preferred. That was unexpected for me.
I think it makes sense that llvm-config has preference.
For example, if you have both llvm-config and llvm-config14 in your path, the results would be llvm-config14 in master and llvm-config with this patch.

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 🙏

@straight-shoota straight-shoota added this to the 1.8.0 milestone Feb 26, 2023
@straight-shoota straight-shoota merged commit 448b4d0 into crystal-lang:master Feb 28, 2023
@straight-shoota straight-shoota deleted the feature/find-llvm-config-preference branch February 28, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants