Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing require for Crystal::ThreadLocalValue #13092

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Add missing require for Crystal::ThreadLocalValue #13092

merged 2 commits into from
Feb 23, 2023

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Feb 19, 2023

@Sija Sija mentioned this pull request Feb 19, 2023
Closed
@straight-shoota
Copy link
Member

I suppose we could consider making this require unconditional. PCRE2 uses ThreadLocalValue already, so it's effectively part of the core library. It should probably be moved to the prelude then.
This would also mean we can drop the additional requires in io/evented.cr and regex/pcre2.cr.
Any thoughts on that?

straight-shoota
straight-shoota approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also fine with merging it as is. We can reorganize later.

@Sija
Copy link
Contributor Author

Sija commented Feb 19, 2023

I have no strong opinions towards either option. I'll leave it for you to decide what's the best way forward.

@straight-shoota straight-shoota added this to the 1.8.0 milestone Feb 20, 2023
@straight-shoota straight-shoota merged commit 0727728 into crystal-lang:master Feb 23, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug platform:windows topic:multithreading topic:stdlib:runtime
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

undefined constant Crystal::ThreadLocalValue on Windows
3 participants
@Sija @straight-shoota @oprypin