Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exhaustive case in HTTP::WebSocket#run #13097

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Use exhaustive case in HTTP::WebSocket#run #13097

merged 2 commits into from
Feb 24, 2023

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Feb 20, 2023

Fairly uncontroversial change.

sdogruyol
sdogruyol approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j8r 👍

@straight-shoota straight-shoota added this to the 1.8.0 milestone Feb 22, 2023
@straight-shoota straight-shoota merged commit 807058a into crystal-lang:master Feb 24, 2023
@j8r j8r deleted the use-exhaustive-case-websocket branch February 24, 2023 11:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib:networking
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@j8r @straight-shoota @sdogruyol @Blacksmoke16