Add Enumerable#in_slices_of
#13108
Add Enumerable#in_slices_of
#13108
Conversation
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
straight-shoota
changed the title
Enumerable#in_slices_of
spec/std/enumerable_spec.cr
Outdated
| it { [1, 2, 3].in_slices_of(1).should eq([[1], [2], [3]]) } | ||
| it { [1, 2, 3].in_slices_of(2).should eq([[1, 2], [3]]) } | ||
| it { [1, 2, 3, 4].in_slices_of(3).should eq([[1, 2, 3], [4]]) } | ||
| it { ([] of Int32).in_slices_of(2).should eq([] of Array(Array(Int32))) } |
There was a problem hiding this comment.
Wrong type:
| it { ([] of Int32).in_slices_of(2).should eq([] of Array(Array(Int32))) } | |
| it { ([] of Int32).in_slices_of(2).should eq([] of Array(Int32)) } |
There was a problem hiding this comment.
This makes me wish for an equality expectation that also takes type into account...
There was a problem hiding this comment.
I'm missing the point about the wrong type when array is empty. shouldn't it be the same as cases where some item is present?
There was a problem hiding this comment.
[] of Array(Array(Int32)) is a three-dimensional structure, whereas the method should only return a two-dimensional structure.
There was a problem hiding this comment.
Right! type is wrong also fot other methods like #in_groups_of and this misled me.
So how i should proceed?
- keep the
[] of Array(Array(Int32))form or change to.should be_empty? - can i search and fix also tests of other method in this PR?
There was a problem hiding this comment.
I don't think making something about this is important. I suggest we merge this and maybe capture a different issue to unify the code.
There was a problem hiding this comment.
I created a new issue to continue the discussion about stricter type checking for equality expectations: #13389. Changing any other specs is out of scope here.
For this PR I think it's best to apply the suggested change to [] of Array(Int32). Then this should be ready to merge.
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
straight-shoota
changed the title
Enumerable#in_slices_ofEnumerable#in_slices_of
Adding missing method and related tests
Resolves #12844