Define Math.pw2ceil for all integer types
#13127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:bug
kind:feature
topic:stdlib:numeric
kind:regression
straight-shoota
approved these changes
Feb 28, 2023
Fryguy
reviewed
Feb 28, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10514. This includes
BigInttoo.The method is reworded in such a way that zero and negative inputs are expected to return 1. In particular,
Math.pw2ceil(Int32::MIN)used to raiseOverflowError, but now also returns 1.Int#next_power_of_twois defined to make dynamic dispatch easier, compared to overloadingMath.pw2ceilfor each integer type individually; we could consider making it public later.