Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PCRE2 fixes to 1.7 #13136

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Backport PCRE2 fixes to 1.7 #13136

merged 6 commits into from
Mar 2, 2023

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota self-assigned this Mar 2, 2023
beta-ziliani
beta-ziliani approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approved witing the result of the nightlies for master

@straight-shoota
Copy link
Member Author

Release workflow running in https://app.circleci.com/pipelines/github/crystal-lang/crystal/11334/workflows/06e52f73-d5c2-4e63-9cbb-d2c2b947ff66
Note it's on a different branch to trigger the CI build because I didn't name this PR branch accordingly, but it's the same commit, 0f0eb1d.

@straight-shoota straight-shoota added this to the 1.7.3 milestone Mar 2, 2023
@straight-shoota straight-shoota merged commit c40f71c into release/1.7 Mar 2, 2023
@straight-shoota straight-shoota deleted the feature/backport-pcre2-fixes branch March 2, 2023 17:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug topic:stdlib:text
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@straight-shoota @beta-ziliani @HertzDevil