-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LLVM 15 #13164
Merged
HertzDevil
merged 9 commits into
crystal-lang:feature/llvm-opaque-pointers
from
HertzDevil:feature/llvm-15
Mar 9, 2023
Merged
Support LLVM 15 #13164
HertzDevil
merged 9 commits into
crystal-lang:feature/llvm-opaque-pointers
from
HertzDevil:feature/llvm-15
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def foo(x)
y = x
if y
if y < 0
p caller
end
else
return 12
end
end
foo(-1)
EDIT: This is apparently fixed by changing the |
beta-ziliani
reviewed
Mar 8, 2023
straight-shoota
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎊
Part of #12743. This PR removes the remaining explicit uses of typed pointers, and also adds a few other things that are not exactly related to opaque pointers.
The manual specs under
spec/llvm-ir
are not adjusted for LLVM 15's opaque pointers yet. This is not that important because those specs' focus was never about pointers.Additional cleanup and refactoring is still needed before this could be merged into the main branch.