Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement File.readlink on Windows #13195

Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Mar 16, 2023

This also enables symlink awareness in a bunch of other APIs (Dir.glob, File.realpath, File.chmod, File.exists?).

Does not support WSL symlinks (IO_REPARSE_TAG_LX_SYMLINK = 0xA000001D).

@HertzDevil HertzDevil marked this pull request as ready for review March 22, 2023 12:35
spec/std/file_spec.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.8.0 milestone Mar 22, 2023
@straight-shoota straight-shoota merged commit 8a509b6 into crystal-lang:master Mar 26, 2023
@HertzDevil HertzDevil deleted the feature/windows-readlink branch March 27, 2023 08:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants