Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip eacces spec for superuser #13227

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Mar 26, 2023

With this patch, file_spec succeeds when run as superuser (ref #13217).

The intent is identical to #13226 but this expectation runs in the main spec process, so doing the same privilege drop is not an option. It would be possible to run the spec in a separate process, but that's very inefficient. It's easier to just skip it when running as superuser. This makes the spec work and we can try to find a better solution later.

@beta-ziliani beta-ziliani added this to the 1.8.0 milestone Mar 27, 2023
@straight-shoota straight-shoota merged commit b314b51 into crystal-lang:master Mar 29, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants