Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress compiler output in compile_file spec helper #13228

Conversation

straight-shoota
Copy link
Member

This patch removes the Using compiled compiler at .build/crystal messages spattered in the spec output because stderr was inherited. Now the stderr and stdout of the compiler process are captured and only printed in case of a failure.

@straight-shoota straight-shoota added this to the 1.8.0 milestone Mar 27, 2023
@straight-shoota straight-shoota merged commit cbba344 into crystal-lang:master Mar 28, 2023
@straight-shoota straight-shoota deleted the feature/spec-suppress-compiler-stderr branch March 28, 2023 16:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants