Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid test.cr in root of repo conflicting with parser warning specs #13259

Merged

Conversation

Blacksmoke16
Copy link
Member

Prevents failing parser/warnings_spec.cr if you happen to have a test.cr file at the root of the repo.

Extracted from #12923.

Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess now it fails if you have a file test.cr in /? 😆
This might actually not be that unlikely on Windows. Perhaps we should rename it test_nonexistent.cr for good measure?

@straight-shoota straight-shoota added this to the 1.8.0 milestone Apr 3, 2023
@straight-shoota straight-shoota merged commit 7b5a849 into crystal-lang:master Apr 4, 2023
@Blacksmoke16 Blacksmoke16 deleted the warnings-spec-file branch April 4, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants