Fix: Remove double URL escape in HTTP::Server::Response.redirect
#13321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threez
changed the title
straight-shoota
approved these changes
Apr 14, 2023
HertzDevil
approved these changes
Apr 15, 2023
straight-shoota
changed the title
HTTP::Server::Response.redirect
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13320
I tried to use the Oauth2::Client from Crystal it suggests to redirect the browser (https://github.com/crystal-lang/crystal/blob/master/src/oauth2/client.cr#L26-L28) after getting the authorization uri. The returned type is an URI already and thus encoded. In my case I was using it to connect to a keycloak, and I wondered, why keycloak doesn't accept the redirect_uri, then I noticed it was encoded twice.
This PR avoids encoding twice.