Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message for calling record macro with kwargs #13367

Merged
merged 7 commits into from
May 12, 2023
Merged

Fix error message for calling record macro with kwargs #13367

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3dcec40
record now accepts kwargs and raises if they are povided
a-alhusaini Apr 20, 2023
64d753c
note that the error occured in the record macro when raising instead …
a-alhusaini Apr 20, 2023
1b29f6e
fixed formatting error
a-alhusaini Apr 20, 2023
a09edda
fixed issue with name first arg
a-alhusaini Apr 27, 2023
b65f966
Merge branch 'master' into add_clearer_message_for_record_typo
a-alhusaini Apr 27, 2023
4cd847d
switch from string to heredoc
a-alhusaini Apr 27, 2023
6539c0a
indent heredoc block. Split name to internal/external arg for clarity
a-alhusaini May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/macros.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,15 @@
# p.copy_with x: 3 # => #<Point(@x=3, @y=2)>
# p # => #<Point(@x=0, @y=2)>
# ```
macro record(name, *properties)
macro record(__name, *properties, **kwargs)
{% raise <<-TXT unless kwargs.empty?
macro `record` does not accept named arguments
Did you mean:

record #{name}, #{(properties + kwargs.map { |name, value| "#{name} : #{value}" }).join(", ").id}
TXT
%}
a-alhusaini marked this conversation as resolved.
Show resolved Hide resolved

struct {{name.id}}
{% for property in properties %}
{% if property.is_a?(Assign) %}
Expand Down