Respect %CC% on Windows
#13376
Merged
Respect %CC% on Windows
#13376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
approved these changes
Apr 21, 2023
src/compiler/crystal/compiler.cr
Outdated
Comment on lines
23
to
24
| CC = ENV["CC"]? || "cc" | ||
| CL = "cl.exe" | ||
| CL = ENV["CC"]? || "cl.exe" |
There was a problem hiding this comment.
I think the naming of these constants is a bit confusing when CL is ENV["CC"].
They are probably pretty unnecessary anyway. The single use is in linker_command. So it doesn't even make much sense to have a constant.
But I'm fine with merging this and refactor afterwards.
WDYT?
straight-shoota
approved these changes
Apr 24, 2023
straight-shoota
requested changes
Apr 25, 2023
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
straight-shoota
approved these changes
Apr 25, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12988.