-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP::Request#form_params
#13418
Merged
straight-shoota
merged 4 commits into
crystal-lang:master
from
threez:http-request-form-params
Jun 15, 2023
Merged
Add HTTP::Request#form_params
#13418
straight-shoota
merged 4 commits into
crystal-lang:master
from
threez:http-request-form-params
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
May 15, 2023
HertzDevil
requested changes
May 16, 2023
@threez Would you mind adressing the review comment? |
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
@straight-shoota, sorry for late reply. I added the changes as requested. |
HertzDevil
approved these changes
Jun 14, 2023
straight-shoota
approved these changes
Jun 14, 2023
straight-shoota
changed the title
add form_params for HTTP::Request
Add Jun 15, 2023
HTTP::Request#form_params
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API has helpers to get the query params for an HTTP request. I was searching io how to handle
a regular http post. I did not find an direct answer, again searching the docs. After a little while I noticed that there are outdated examples on stack overflow. To safe everybody else the hassle of searching how to get form params, I added
convenience helpers in the spirit of
query_params
.This will enable uses like this: