Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Server should allow custom concurrency models #13428

Merged
merged 1 commit into from
May 6, 2023
Merged

HTTP Server should allow custom concurrency models #13428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/http/server.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,12 @@ class HTTP::Server
listen
end

# Overwrite this method to implement an alternative concurrency handler
# one example could be the use of a fiber pool
protected def dispatch(io)
spawn handle_client(io)
end

# Starts the server. Blocks until the server is closed.
def listen : Nil
raise "Can't re-start closed server" if closed?
Expand All @@ -465,9 +471,7 @@ class HTTP::Server
end

if io
# a non nillable version of the closured io
_io = io
spawn handle_client(_io)
dispatch(io)
else
break
end
Expand Down