Fixup for JSON::Serializable on certain recursively defined types
#13430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
kind:bug
topic:stdlib:serialization
kind:regression
|
This essentially reverts part of #13344 which apparently wasn't necessary? I suppose the relevant part of that PR was casting the type of the default nil value? It's not exactly clear why this fixes things. The compiler is doing some weird stuff here. |
|
yes looks like compiler bug when using |
HertzDevil
requested changes
May 4, 2023
src/json/serialization.cr
Outdated
| @@ -202,9 +203,9 @@ module JSON | |||
| # recursively defined serializable types | |||
| {% for name, value in properties %} | |||
| %var{name} = {% if value[:has_default] || value[:nilable] %} | |||
| nil.as(::Nil | typeof(@{{name}})) | |||
| nil.as(::Nil | Union({{value[:type]}})) | |||
There was a problem hiding this comment.
Suggested change
| nil.as(::Nil | Union({{value[:type]}})) | |
| nil.as(::Union(::Nil, typeof(@{{name}}))) |
For the others simply wrap the typeof alone inside ::Union (also note the leading ::)
straight-shoota
approved these changes
May 4, 2023
|
I am also observing some JSON bug, possibly slightly different, in Crystal 1.8.1. |
straight-shoota
changed the title
JSON::Serializable on certain recursively defined types
straight-shoota
pushed a commit
that referenced
this pull request
May 5, 2023
This was referenced May 5, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't know, correct this or not, but if fixes, and all specs seems pass. fixes: #13429