Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start_day parameter to Time#at_beginning_of_week #13446

Merged
merged 10 commits into from
May 24, 2023
Merged

Add start_day parameter to Time#at_beginning_of_week #13446

merged 10 commits into from
May 24, 2023

Commits on May 8, 2023

  1. Allow an optional start_day argument for Time#at_beginning_of_week

    @DanielGilchrist
    DanielGilchrist committed May 8, 2023
    Configuration menu
    Copy the full SHA
    a34867d View commit details
    Browse the repository at this point in the history

  2. Add test cases for if an invalid String or Symbol argument are pa… 

    …ssed
    @DanielGilchrist
    DanielGilchrist committed May 8, 2023
    Configuration menu
    Copy the full SHA
    106bec6 View commit details
    Browse the repository at this point in the history

  3. Drop String | Symbol overload and instead leverage Symbol autocasting 

    https://crystal-lang.org/reference/1.8/syntax_and_semantics/autocasting.html#symbol-autocasting
    @DanielGilchrist
    DanielGilchrist committed May 8, 2023
    Configuration menu
    Copy the full SHA
    fdb71f8 View commit details
    Browse the repository at this point in the history

  4. Run crystal tool format

    @DanielGilchrist
    DanielGilchrist committed May 8, 2023
    Configuration menu
    Copy the full SHA
    c277911 View commit details
    Browse the repository at this point in the history

  5. Use autocasting in definition 

    Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
    @DanielGilchrist @Sija
    DanielGilchrist and Sija committed May 8, 2023
    Configuration menu
    Copy the full SHA
    614478c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merge branch 'master' into at-beginning-of-week-start-day

    @DanielGilchrist
    DanielGilchrist committed May 16, 2023
    Configuration menu
    Copy the full SHA
    261e71b View commit details
    Browse the repository at this point in the history

  2. Simplify documentation, use a more interesting example than monday an… 

    …d show en example without an argument

Co-Authored-By: Sijawusz Pur Rahnama <sija@sija.pl>
    @DanielGilchrist @Sija
    DanielGilchrist and Sija committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a08f0d2 View commit details
    Browse the repository at this point in the history

  3. Add specs to assert hour, minute and day is set to 0 when using `Time… 

    …#at_beginning_of_week`
    @DanielGilchrist
    DanielGilchrist committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a4b6914 View commit details
    Browse the repository at this point in the history

  4. Use a fixed timestamp in documentation 

    Co-authored-by: Johannes Müller <straightshoota@gmail.com>
    @DanielGilchrist @straight-shoota
    DanielGilchrist and straight-shoota committed May 16, 2023
    Configuration menu
    Copy the full SHA
    85cc6b3 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merge branch 'master' into at-beginning-of-week-start-day

    @DanielGilchrist
    DanielGilchrist committed May 18, 2023
    Configuration menu
    Copy the full SHA
    071c709 View commit details
    Browse the repository at this point in the history