New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make `fcntl` defined on all platforms #13495

Merged

straight-shoota merged 1 commit into crystal-lang:master from HertzDevil:bug/fcntl

May 24, 2023

Contributor

HertzDevil commented May 23, 2023 •

edited

Loading

Allows IO::FileDescriptor.fcntl on WebAssembly, since the binding for it appears to have been used for Socket.fcntl already.
Raises NotImplementedError on Windows, preventing a compilation error and a link error.


          Make fcntl defined on all platforms

9e7ee0f

HertzDevil added kind:bug platform:windows topic:stdlib:files platform:wasm topic:stdlib:networking labels

straight-shoota approved these changes

View reviewed changes

straight-shoota added this to the 1.9.0 milestone

straight-shoota merged commit 61a2c52 into crystal-lang:master

HertzDevil deleted the bug/fcntl branch

May 24, 2023 18:26

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug platform:wasm platform:windows topic:stdlib:files topic:stdlib:networking