Distribute DLLs and import libraries on Windows #13543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds all DLLs and their import libraries, and bundles them as part of the unofficial nightly Windows artifacts. It also splits the single CI job into multiple jobs for better organization. (As a consequence, since different jobs may use runner images with different versions, it is no longer possible to include the MSVC version as part of the libraries' cache keys.)
The whole standard library, except for the LLVM components, should now work with
-Dpreview_dll. LLVM is still built statically and with/MT, sostd_specwill print a warning about mixed CRT library usage. To get rid of the warning, build a separate LLVM that uses-DLLVM_USE_CRT_RELEASE=MDinstead, and point%LLVM_CONFIG%inside it. (To get rid of static linking altogether we must first port the remaining functions inllvm_ext.cc, because LLVM only exposes its C interface on Windows when DLLs are used.)