Make BigDecimal's comparisons exact
#13554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Jun 14, 2023
straight-shoota
approved these changes
Jun 15, 2023
|
This PR broke the simple |
|
That's because 1.1 is indeed not equal to 1.100000000000000088817841970012523233890533447265625. This is not a bug, use |
|
Hm, I suppose the confusing part of this is that |
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversions from
BigRational | FloattoBigDecimalare inexact, but conversions fromBigDecimal | FloattoBigRationalare exact, so the latter ones are used to implement#<=>.Comparisons between
BigDecimalandFloat::Primitivenow respect infinities and NaNs.