Add Enumerable#each_step and Iterable#each_step
#13610
Conversation
straight-shoota
changed the title
Enumerable#each_step and Iterable#each_step
|
is there anything else that needs updates at this point? It doesn't seem like there is anything outstanding, but it isn't approved yet. |
spec/std/enumerable_spec.cr
Outdated
| it "doesn't accept a negative step" do | ||
| expect_raises(ArgumentError) do | ||
| %w[a b c d e f].each_step(-2) | ||
| end | ||
| end | ||
|
|
||
| it "doesn't accept a step of 0" do | ||
| expect_raises(ArgumentError) do | ||
| %w[a b c d e f].each_step(0) | ||
| end | ||
| end | ||
|
|
||
| it "doesn't accept a negative offset" do | ||
| expect_raises(ArgumentError) do | ||
| %w[a b c d e f].each_step(2, offset: -2) | ||
| end | ||
| end |
There was a problem hiding this comment.
These specs only cover exceptions raised by Iterator#skip and Iterator#step, the Enumerable#each_step forms are not tested
There was a problem hiding this comment.
good catch, I had it in my mind that the iterator validation would carry over. I've added the validation to Enumerable#each_step.
spec/std/enumerable_spec.cr
Outdated
| describe "each_step" do | ||
| it_iterates "yields every 2nd element", %w[a c e], %w[a b c d e f].each_step(2) | ||
| it_iterates "accepts an optional offset parameter", %w[b d f], %w[a b c d e f].each_step(2, offset: 1) | ||
| it_iterates "accepts an optional offset parameter of 0", %w[a c e], %w[a b c d e f].each_step(2, offset: 0) |
There was a problem hiding this comment.
I would like extra spec(s) where n > 0 && (n <= offset < size), which would skip some elements at the beginning
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
|
@HertzDevil can you take another look at this? |
|
@HertzDevil I hate to have to ping you again for this, but I believe this is ready to be reviewed / merged now. |
|
@HertzDevil can you review this again? I think it's ready to be merged and I'd like to get it in for 1.10.0. |
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Fixes #13583