Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Set(T) instead of Hash(T, Bool) #13611

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Use Set(T) instead of Hash(T, Bool) #13611

merged 1 commit into from
Jul 21, 2023

Conversation

HertzDevil
Copy link
Contributor

All these hashes do not care about the difference between a false key and a non-existent key, so a Set is more appropriate.

This also removes a few double lookups.

@straight-shoota straight-shoota added this to the 1.10.0 milestone Jun 30, 2023
@straight-shoota straight-shoota merged commit d7a7df3 into crystal-lang:master Jul 21, 2023
@HertzDevil HertzDevil deleted the refactor/hash-of-bool branch July 24, 2023 16:03
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@HertzDevil @Blacksmoke16
Use Set(T) instead of Hash(T, Bool) (crystal-lang#13611)
7a84e83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib:collection
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota