Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reopen current file in File#utime on Windows #13625

Merged

Conversation

HertzDevil
Copy link
Contributor

Opening the file is still needed in the corresponding class method (File.utime).

@HertzDevil HertzDevil added kind:refactor platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files labels Jul 3, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone Jul 3, 2023
@straight-shoota straight-shoota merged commit b354130 into crystal-lang:master Jul 4, 2023
@HertzDevil HertzDevil deleted the refactor/windows-file-utime branch July 5, 2023 13:34
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants