Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add crystal tool dependencies #13631

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Feature: Add crystal tool dependencies #13631

merged 7 commits into from
Sep 27, 2023

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Jul 4, 2023 •
edited
Loading

This is a PR for a feature branch adding the crystal tool dependencies command.

Resolves #11481

@straight-shoota @HertzDevil
Add crystal tool dependencies (#13613)
8ddf285 
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
@straight-shoota straight-shoota self-assigned this Jul 4, 2023
@straight-shoota straight-shoota mentioned this pull request Jul 4, 2023
Merged
@straight-shoota straight-shoota changed the title Add crystal tool dependencies Feature: Add crystal tool dependencies Jul 4, 2023
This was referenced Jul 6, 2023
Merged
Closed
@straight-shoota straight-shoota mentioned this pull request Jul 13, 2023
Merged
straight-shoota and others added 2 commits August 14, 2023 23:38
@straight-shoota @Sija @caspiano
Add dot and mermaid outputs (#13660)
9ddb3e1 
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Co-authored-by: Caspian Baska <email@caspian.computer>
@straight-shoota
Add shell completion
fab9891
@straight-shoota straight-shoota marked this pull request as ready for review September 8, 2023 14:42
beta-ziliani
beta-ziliani approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor and pretty much ignorable comment.

EDIT: as mentioned privately, I haven't checked the autocomplete files

src/compiler/crystal/command.cr Show resolved Hide resolved
src/compiler/crystal/command.cr
output_format = f
if dependencies
opts.on("-f tree|flat|dot|mermaid", "--format tree|flat|dot|mermaid", "Output format tree (default), flat, dot, or mermaid") do |f|
dependency_output_format = DependencyPrinter::Format.parse?(f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is the below mentioned above)

@straight-shoota straight-shoota added this to the 1.10.0 milestone Sep 25, 2023
@straight-shoota straight-shoota merged commit 09d71d4 into master Sep 27, 2023
106 checks passed
@straight-shoota straight-shoota deleted the feature/tool-dependencies branch September 27, 2023 08:27
@straight-shoota straight-shoota mentioned this pull request Oct 9, 2023
Merged
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@straight-shoota @HertzDevil
@Sija @caspiano @Blacksmoke16
Feature: Add crystal tool dependencies (crystal-lang#13631)
35b1ffd 
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Co-authored-by: Caspian Baska <email@caspian.computer>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:feature topic:tools:dependencies
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

crystal tool dependencies: Displaying compile-time source dependencies
2 participants
@straight-shoota @beta-ziliani