Use IO::DEFAULT_BUFFER_SIZE in Digest#update
#13635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is about 20% faster when the `io` doesn't have read buffering enabled.
straight-shoota
approved these changes
Jul 5, 2023
straight-shoota
changed the title
IO::DEFAULT_BUFFER_SIZE in Digest#update
beta-ziliani
approved these changes
Jul 5, 2023
|
But where do you cross the line then? 😆 |
|
Ah, the dilemma! To follow the rules or to follow the heart? |
|
But I don't think this is really urgent. If you really want the improved spead ahead of its release it's easy to patch this method in. |
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is about 20% faster when the
iodoesn't have read buffering enabled.