Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DLL delay-load opt-in #13645

Merged

Conversation

HertzDevil
Copy link
Contributor

This is a temporary workaround for #13644 for Crystal 1.9 until we could figure out whether the linker error can be fixed.

@HertzDevil HertzDevil added kind:bug platform:windows topic:compiler:codegen kind:regression Something that used to correctly work but no longer works labels Jul 10, 2023
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@straight-shoota straight-shoota added this to the 1.9.0 milestone Jul 10, 2023
@straight-shoota straight-shoota merged commit e2222d4 into crystal-lang:master Jul 10, 2023
52 checks passed
@HertzDevil HertzDevil deleted the bug/delay-load-opt-in branch July 10, 2023 22:47
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug kind:regression Something that used to correctly work but no longer works platform:windows topic:compiler:codegen
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants