Change spec runner to exit with failure for focus: true
#13653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of the spec runner: In focus mode, the exit code of successful runs will be overriden to
1
to prevent CI from silently running on a subset of tests due to an accidentally commitedfocus: true
.focus: true
is typically used in interactive mode where the print output is most important for the user to understand if the spec run was successful. The failure status code should not have any effect in this use case.The old behiavour can be regained by setting the environment variable
SPEC_FOCUS_NO_FAIL=1
. Then the exit code will be success (0
) if all focused specs succeed.Resolves #10989