Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Serializable with converter parsing null value #13656

Conversation

straight-shoota
Copy link
Member

Resolves #13655

@straight-shoota straight-shoota added kind:bug topic:stdlib:serialization kind:regression Something that used to correctly work but no longer works labels Jul 13, 2023
@straight-shoota straight-shoota self-assigned this Jul 13, 2023
@straight-shoota straight-shoota added this to the 1.9.1 milestone Jul 13, 2023
@straight-shoota straight-shoota merged commit 9865d21 into crystal-lang:master Jul 14, 2023
52 checks passed
@straight-shoota straight-shoota deleted the fix/serializable-converter-null branch July 14, 2023 07:33
stakach pushed a commit to stakach/crystal that referenced this pull request Jul 22, 2023
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:stdlib:serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Converter on nilable field in JSON::Serializable fails when reading null value
2 participants