Refactor LLVM.default_target_triple to avoid regex
#13659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeopJr
reviewed
Jul 13, 2023
HertzDevil
requested changes
Jul 14, 2023
HertzDevil
requested changes
Jul 24, 2023
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
HertzDevil
approved these changes
Jul 24, 2023
nobodywasishere
approved these changes
Jul 29, 2023
beta-ziliani
deleted the
refactor/remove-regex-llvm.default_target_triple
branch
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
) There's no need to use regex for matching plain strings in LLVM.default_target_triple. I replaced it with String#starts_with?. The functional equivalent would've been #includes? but as far as I am aware, the target triple always starts with the arch so this there should never be anything before these search strings. Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to use regex for matching plain strings in
LLVM.default_target_triple.I replaced it with
String#starts_with?. The functional equivalent would've been#includes?but as far as I am aware, the target triple always starts with the arch so this there should never be anything before these search strings.