Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON::Serializable in scripts/generate_ssl_server_defaults.cr #13667

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jul 14, 2023

Version 5.7 adds DHE-RSA-CHACHA20-POLY1305 to CIPHERS_INTERMEDIATE.

Also replaces the JSON::Any with JSON::Serializables.

@straight-shoota
Copy link
Member

I would prefer to have two separate PRs for this: A refactor and regenerate with new feature(s).

@HertzDevil HertzDevil changed the title Update OpenSSL::SSL::Context default ciphers Use JSON::Serializable in scripts/generate_ssl_server_defaults.cr Jul 24, 2023
@straight-shoota straight-shoota added this to the 1.10.0 milestone Jul 24, 2023
@straight-shoota straight-shoota merged commit ffa176f into crystal-lang:master Jul 25, 2023
52 of 53 checks passed
@HertzDevil HertzDevil deleted the refactor/update-openssl-cipher-defaults branch August 1, 2023 17:07
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants