-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Process.on_terminate
#13694
Merged
straight-shoota
merged 52 commits into
crystal-lang:master
from
stakach:improve-process-on_interrupt
Feb 27, 2024
Merged
Add Process.on_terminate
#13694
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
e153e8e
pass details on interrupt
stakach 2ad9331
fix win32 handler def
stakach 006ce08
update public interface
stakach 4ef574f
fix windows build
stakach 0fa95aa
add missed windows constants
stakach 7f54152
Merge branch 'master' into improve-process-on_interrupt
stakach cbd80e9
Merge branch 'master' into improve-process-on_interrupt
stakach 78c27f1
Merge branch 'master' into improve-process-on_interrupt
stakach 1ed9f63
Merge branch 'master' into improve-process-on_interrupt
stakach f9a6263
Merge branch 'master' into improve-process-on_interrupt
stakach 2044e94
use Process::ExitReason enum
stakach 360a3b5
remove alias
stakach 2533fad
fix windows class vars
stakach 6d94721
Merge branch 'master' into improve-process-on_interrupt
stakach 0604bd2
Merge branch 'master' into improve-process-on_interrupt
stakach 8e43767
Merge branch 'master' into improve-process-on_interrupt
stakach ee8f672
Merge branch 'master' into improve-process-on_interrupt
stakach 0ea6ecb
win32 backwards compat
stakach 118baff
remove type requirements
stakach 793f0a6
fix wasi compatibility
stakach 5765c73
unix with compatibility
stakach 2352065
fix compilation
stakach 33c9ac6
improve readability of win32 proc type
stakach 0a11eb5
Update src/process.cr
stakach bdc8541
Update src/process/status.cr
stakach a2bc368
Update src/process/status.cr
stakach 6bcf166
fix win32 compilation
stakach d497f08
minor performance improvement
stakach 721444e
Merge branch 'master' into improve-process-on_interrupt
stakach 38c8b51
Merge branch 'master' into improve-process-on_interrupt
stakach f81bb9b
Merge branch 'master' into improve-process-on_interrupt
stakach 56115e0
Merge branch 'master' into improve-process-on_interrupt
stakach 22a9b34
Merge branch 'master' into improve-process-on_interrupt
stakach 78e8047
deprecate on_interrupt and use on_terminate
stakach d70ee33
fix call to on_terminate
stakach f460d5c
fix win32
stakach a740d4a
improve win32 on_terminate
stakach 757079b
update docs
stakach 79cbc17
change wording in description
stakach bc66bdb
add example code
stakach 2b91b7d
crystal tool format
stakach fc279c4
Merge branch 'master' into improve-process-on_interrupt
stakach 79c848d
Merge branch 'master' into improve-process-on_interrupt
stakach 35471c9
Merge branch 'master' into improve-process-on_interrupt
stakach 962d654
fix comments and specs for new enum values
stakach 3ceb646
Merge branch 'master' into improve-process-on_interrupt
stakach 8972255
Merge branch 'master' into improve-process-on_interrupt
stakach 539b998
Merge branch 'master' into improve-process-on_interrupt
stakach 0319fc3
Merge branch 'master' into improve-process-on_interrupt
stakach 66b4ce0
Merge branch 'master' into improve-process-on_interrupt
stakach f4a3374
Merge branch 'master' into improve-process-on_interrupt
stakach bfdef38
Merge branch 'master' into improve-process-on_interrupt
stakach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: IMO it would not necessary to deprecate this method. It's just the backend of
Process.on_interrupt
and should never be called directly. It doesn't hurt to have the deprecation, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I put it there so it would be simpler to find and remove at a later date. Let me know if you want me to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think it's fine. Thanks!