Fix byte sizes for Procs inside extern structs
#13711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beta-ziliani
approved these changes
Jul 28, 2023
straight-shoota
changed the title
Procs inside extern structsProcs inside extern structs
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
…tal-lang#13711) Extern structs store `Proc`s without the closure pointer, so they should use `llvm_embedded_c_type` rather than `llvm_embedded_type` for the correct byte sizes. The total sizes of the extern structs themselves are already correct and unaffected by this PR.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extern structs store
Procs without the closure pointer, so they should usellvm_embedded_c_typerather thanllvm_embedded_typefor the correct byte sizes.The total sizes of the extern structs themselves are already correct and unaffected by this PR.