Optimize IO#read_string(0)
#13732
Merged
Optimize IO#read_string(0)
#13732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests failing in CI have been failing on previous commits on the |
jgaskins
force-pushed
the
optimize-io-read-string-empty
branch
from
355ff5b
to
bff4ebc
Compare
|
yup, interpreter std tests are flaky indeed. |
HertzDevil
approved these changes
Aug 9, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching an empty string from a remote server, we can avoid a heap allocation by returning an empty string as an optimized special case.
I also checked and
IO#read_fully(slice : Slice)does not need this optimization. It already short-circuits if there is nothing to read.