Add additional fields to GC:ProfStats
#13734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
approved these changes
Aug 9, 2023
jkthorne
reviewed
Aug 10, 2023
| @@ -66,7 +66,9 @@ module GC | |||
| gc_no : UInt64, | |||
| markers_m1 : UInt64, | |||
| bytes_reclaimed_since_gc : UInt64, | |||
| reclaimed_bytes_before_gc : UInt64 | |||
| reclaimed_bytes_before_gc : UInt64, | |||
| expl_freed_bytes_since_gc : UInt64, | |||
There was a problem hiding this comment.
I know this is is the same naming as Boehm but should this be more clear
maybe something like explicitly_freed_bytes_since_gc
There was a problem hiding this comment.
We're going with the library names everywhere else, so it's fine to keep that here as well.
|
Something to consider: as I understand, anyone who has libgc < 8 will now experience a crash? Or was it already unsupported? |
|
LibGC 8.0.0 was released in 2018. At least in Linux all precompiled
compilers comes with (a modern) libgc as a static library. In homebrew and
freebsd the LibGC are also modern.
…On Thu, 10 Aug 2023, 08:24 Oleh Prypin, ***@***.***> wrote:
Something to consider: as I understand, anyone who has libgc < 8 will now
experience a crash? Or was it already unsupported?
—
Reply to this email directly, view it on GitHub
<#13734 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABL6TSUERB6OT5SSN37O2TXUR5CXANCNFSM6AAAAAA3IH3D7U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The function is not supposed to break because it requires passing |
oprypin
approved these changes
Aug 10, 2023
straight-shoota
changed the title
GC:ProfStats
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Available since Boehm GC 8.0.0:
https://github.com/ivmai/bdwgc/blob/v8.0.0/include/gc.h#L726