Remove double .cr.cr extension in require path lookup
#13749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a require path ends in
.cr, some lookup paths would end up with a double extension.cr.cr. This is pretty unlikely to be ever intended. An example use case is a shard name that ends in.cr(see #8665, this patch is the first stage for fixing this issue).This patch removes the double extensions to make lookup paths more reasonable. The main change is happening in ed8a8b2. The spec changes in this commit clearly show the effects.
It would be possible to maintain backwards compatibility by keeping the old paths around. I don't think this is really necessary because the filenames are so weird and I don't expect that to be used.
So I'd rather prefer it as a simple replacement. If we notice any issues, we can add the removed paths back in.
This addresses part of #13210