Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Process.new with nilable chdir parameter on Windows #13768

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix Process.new with nilable chdir parameter on Windows #13768

merged 1 commit into from
Sep 5, 2023

Conversation

straight-shoota
Copy link
Member

Resolves #13767

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:system labels Aug 25, 2023
@straight-shoota straight-shoota self-assigned this Aug 25, 2023
@straight-shoota straight-shoota added this to the 1.10.0 milestone Sep 4, 2023
@straight-shoota straight-shoota merged commit 574d8f4 into crystal-lang:master Sep 5, 2023
51 of 53 checks passed
@straight-shoota straight-shoota deleted the fix/win32-process-nilable-chdir branch September 5, 2023 11:37
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@straight-shoota @Blacksmoke16
Fix Process.new with nilable chdir parameter on Windows (crystal-la…
02dbd5a 
…ng#13768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:system
Projects
None yet
Milestone
1.10.0
2 participants
@straight-shoota @HertzDevil