Add types to HTTP::StaticFileHandler
#13778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds types to StaticFuleHandler initialize and move the assignment to the arg assignemnt
|
Hm, this is technically a breaking change because things like So maybe we should add an unrestricted overload just to be safe? # :ditto:
@[Deprecated]
def self.new(public_dir : String, fallthrough = true, directory_listing = true)
new(public_dir, fallthrough: fallthrough, listing: listing)
endI don't know... maybe that's too much caution. I cannot see an actual justified use case for a non-Bool type parameter. |
jkthorne
force-pushed
the
types/static-file-handler/init
branch
from
81d358f
to
73f16b1
Compare
Sija
reviewed
Aug 30, 2023
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
straight-shoota
approved these changes
Aug 31, 2023
|
Why add the breaking change label again? It should no longer be due to the new overload. |
|
It adds a depreciation and deprecations are marked as breaking changes. |
|
Don't we now have a separate deprecation tag |
|
Oops right. Guess I was out on vacation for too long 😏 |
beta-ziliani
approved these changes
Sep 7, 2023
straight-shoota
changed the title
HTTP::StaticFileHandler
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl> Co-authored-by: Jack Thorne <jack@myrenee.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds types to StaticFuleHandler initialize and move the assignment to the arg assignemnt