Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid realloc callstack array when unwinding #13781

Merged

Conversation

carlhoerberg
Copy link
Contributor

Most often the callstack is larger than 3, don't know if 16 is resonable value, but at least it avoid realloc the array in many apps.

Most often the callstack is larger than 3, don't know if 16 is resonable
value, but at least it avoid realloc the array in many apps.
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It might be worth considering increasing the capacity even more. That's just a gut feeling. But it's a hard choice to make with lacking copmrehensive insights. I'm happy to got with 16.

@carlhoerberg
Copy link
Contributor Author

increased to 32

@beta-ziliani beta-ziliani added this to the 1.10.0 milestone Aug 30, 2023
@straight-shoota straight-shoota merged commit 9fb416e into crystal-lang:master Sep 4, 2023
53 checks passed
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants