Support Unicode 15.1.0 #13812
Merged
Support Unicode 15.1.0 #13812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementing GB9c seems non-trivial. It requires information which is currently unavailable in the break detection algorithm. I'm not sure how it could be integrated into the current implementation. |
straight-shoota
approved these changes
Sep 20, 2023
Sija
reviewed
Sep 20, 2023
| @@ -61,7 +64,7 @@ File.open(path, "w") do |file| | |||
| graphemes << string_or_char(grapheme.to_s) | |||
| end | |||
|
|
|||
| file.puts " it_iterates_graphemes #{string.dump}, [#{graphemes.join(", ", &.dump)}] # #{comment}" | |||
| file.puts " #{%(pending "GB9c" { ) if pending} it_iterates_graphemes #{string.dump}, [#{graphemes.join(", ", &.dump)}] #{" }" if pending} # #{comment}" | |||
There was a problem hiding this comment.
This line became bit hard to read, it might be helpful to unpack it.
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grapheme break specs have roughly doubled in size and
are currently failingsome are now marked as pending due to the addition of rule GB9c to the list of grapheme cluster boundary rules in UAX29 Revision 43.cc @straight-shoota @naqvis