Fix Char::Reader#each bounds check after block
#13817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
changed the title
Char::Reader#each bounds check with nested loop in blockChar::Reader#each bounds check after block
HertzDevil
previously approved these changes
Sep 19, 2023
|
Oh that's a nice one. Specs are failing everywhere in stdlib but EDIT: Yeah that won't fail if there's an extra null character 🤷 crystal/spec/std/char/reader_spec.cr Lines 75 to 79 in 1898dfc |
HertzDevil
approved these changes
Sep 20, 2023
bcardiff
approved these changes
Sep 20, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13816