Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS for tables #13822

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Add CSS for tables #13822

merged 5 commits into from
Sep 26, 2023

Conversation

nobodywasishere
Copy link
Contributor

@nobodywasishere nobodywasishere commented Sep 21, 2023 •
edited
Loading

Add CSS for tables that matches code blocks (#11899)

Sija
Sija reviewed Sep 21, 2023
View reviewed changes
src/compiler/crystal/tools/doc/html/css/style.css Outdated
Comment on lines 267 to 280
.superclass-hierarchy .superclass + .superclass::before {
.superclass-hierarchy .superclass+.superclass::before {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I find (all occurrences of) this change less readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can revert it - it was just the default formatting performed by VS Code.

Copy link
Contributor

@Sija Sija Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to the core team to decide. The rest of the changes are also quite subjective btw, as they depend heavily on your prettier configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow, other than the formatting this just adds table css and allowing splits between namespaces

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the formatting-related ones.

@straight-shoota
Copy link
Member

I'd prefer three separate PRs for these changes. They are pretty much unrelated to each other than that some of the same files are touched.

@nobodywasishere nobodywasishere changed the title Minor documentation CSS improvements Add CSS for tables Sep 23, 2023
@straight-shoota straight-shoota added this to the 1.10.0 milestone Sep 25, 2023
@straight-shoota straight-shoota merged commit b5065f0 into crystal-lang:master Sep 26, 2023
53 checks passed
@nobodywasishere nobodywasishere deleted the nobody/doc-css-improvs branch September 26, 2023 16:51
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@nobodywasishere @Blacksmoke16
Add CSS for tables (crystal-lang#13822)
f316c63
@Blacksmoke16 Blacksmoke16 linked an issue Jul 20, 2024 that may be closed by this pull request
Table formatting in Crystal documentation #11899
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@HertzDevil HertzDevil HertzDevil approved these changes

Assignees
No one assigned
Labels
kind:feature topic:tools:docs-generator
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Table formatting in Crystal documentation
5 participants
@nobodywasishere @straight-shoota @Sija @HertzDevil @Blacksmoke16