Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IO::Error#target #13865

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add IO::Error#target #13865

merged 2 commits into from
Nov 28, 2023

Conversation

straight-shoota
Copy link
Member

Alternative to #13852 (see explanation there)

@straight-shoota straight-shoota self-assigned this Oct 6, 2023
@straight-shoota straight-shoota mentioned this pull request Nov 13, 2023
Closed
HertzDevil
HertzDevil approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@HertzDevil HertzDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check if this covers all possible IO::Error exceptions, but we can always add any missing ones later

@straight-shoota straight-shoota added this to the 1.11.0 milestone Nov 27, 2023
@straight-shoota straight-shoota merged commit 9082692 into crystal-lang:master Nov 28, 2023
54 of 55 checks passed
@straight-shoota straight-shoota deleted the feat/io-error-target branch November 28, 2023 17:26
@HertzDevil HertzDevil mentioned this pull request Nov 30, 2023
Merged
@straight-shoota straight-shoota mentioned this pull request Dec 5, 2023
Closed
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@straight-shoota @Blacksmoke16
Add IO::Error#target (crystal-lang#13865)
4c2e77e
@BrewTestBot BrewTestBot mentioned this pull request Jan 8, 2024
Merged
1 task
@straight-shoota straight-shoota mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:feature topic:stdlib:files
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @HertzDevil