Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android API levels 24 - 27 #13884

Merged

Conversation

HertzDevil
Copy link
Contributor

Fixes #13883.

@I3oris The ioctl definition in the REPLy shard has been modified because it is incompatible with Bionic C's definition, needed by this PR. Feel free to incorporate this into upstream.

@straight-shoota
Copy link
Member

reply is is the upstream repo for the lib/reply subtree in this directory. Any change we do in that directory should be upstreamed to keep in sync. Or better: apply it upstream first and then downstream it by pulling the subtree.

@HertzDevil
Copy link
Contributor Author

So in case of those upstream repos ever becomes inactive (and we don't take ownership), does that permanently prevent us from applying patches like this?

@straight-shoota
Copy link
Member

Then we could fork our own upstream.
Or break the subtree connection entirely. If the upstream repo is inactive, there's no reason to stay in sync anyway.

@straight-shoota
Copy link
Member

straight-shoota commented Oct 11, 2023

The objective is that we should always be able to pull in the latest upstream changes with git subtree pull --prefix lib/reply https://github.com/I3oris/reply main. Without having to resolve conflicts because we added our own modifications.

HertzDevil added a commit to HertzDevil/reply that referenced this pull request Oct 11, 2023
@straight-shoota
Copy link
Member

straight-shoota commented Oct 11, 2023

I just realized that for some reason lib/reply isn't actually setup as a subtree. Apparently we messed that up when intrudocing the dependency. We'll have to fix that, but not in this PR.

@straight-shoota straight-shoota modified the milestones: 1.11.0, 1.10.1 Oct 11, 2023
@straight-shoota straight-shoota merged commit 1d0a7ab into crystal-lang:master Oct 12, 2023
54 checks passed
@HertzDevil HertzDevil deleted the feature/android-api-level-24 branch October 17, 2023 10:16
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature kind:regression Something that used to correctly work but no longer works platform:android topic:stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crystal 1.10 no longer builds on Termux
2 participants