Fix infinite recursion of expanded nodes in UnreachableVisitor
#13922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already remembering which def bodies have been visited in order to prevent revisits. Apparently, `ExpandableNode` can be reached multiple times as well. This patch generalizes the register to contain any `ASTNode` and uses it for `ExpandableNode` as well.
straight-shoota
added
kind:bug
This was referenced Nov 1, 2023
HertzDevil
approved these changes
Nov 4, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already remembering which def bodies have been visited in order to prevent revisits. Apparently,
ExpandableNodecan be reached multiple times as well.This patch generalizes the register to contain any
ASTNodeand uses it forExpandableNodeas well.This bug appeard for
crystal tool unreachable spec/compiler_spec.cr. With this patch it works fine.I could not find a reduced example for a spec.