Add annotations to output of crystal tool unreachable
#13927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
approved these changes
Nov 1, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
This was referenced Jan 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations can be helpful for analyzing unreachable defs. For example, a def with annotation
Deprecatedcould be considered as less relevant.This information is easily available, so it's a simple to change to make it available in the output.
Example output:
foobar.cr:1:1 top-level foo 3 lines foobar.cr:7:1 top-level foo 3 lines @[Deprecated("You should use bar")] @[Experimental] foobar.cr:11:1 top-level bar 3 lines @[Deprecated("You should use foo\nreally!")]