Fix portable shell command arguments in Process#prepare_args

[GeopJr]

fix: #13919

Not sure if the discussion on #13919 is done, but pushing it as a start just in case there are any issues missed

I haven't noticed anything on linux-gnu and was able to compile the compiler with it. BSDs might need more testing if the smoke test is not enough though

[straight-shoota]

BSDs might need more testing if the smoke test is not enough though

Yeah, smoke tests just cross-compile and don't run anything. So they just make sure the stuff builds, but not that it works as intended.

[straight-shoota]

It looks like a great simple patch and it appears to fit for all platforms. So 👍 from me!

[GeopJr]

FreeBSD

Compiler can compile the compiler but std spec failed with the following:

Debugging the first one:

it might have to do with crystal being a system package 🤷

This is probably the first time std spec ran on FreeBSD since 1.7.3, including PCRE2

I'm not going to run compiler specs, but I'll give running std specs with the system one and on dragonflyBSD a try and update this comment

edit 1: using the 1.7.3 compiler for std_spec also failed with the same ones
edit 2:

DragonFlyBSD

Compiler can compile itself, std_spec gets stuck at some point, I had to prematurely stop it (after multiple runs plus release builds)

Debugging the string ones since it's concerning:

However, running the freebsd iconv workaround works

The vm doesn't make it easy to debug why it stalls so I'll run the specs that use process manually

• process_spec passed
• kernel_spec passed
• signal_spec passed
• call_stack_spec passed
• file_descriptor_spec passed
• file_executable_spec passed
• utils_spec passed
• call_stack_spec passed