Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro methods for Include and Extend #14064

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Dec 7, 2023

Resolves part of #3274.

Note that #14063 is not required for these nodes to be accessible in the macro language, because grammatically include and extend can be directly passed to macros:

module Foo
  macro foo(x)
    {% p! x, x.name, x.class_name %} # okay
  end

  foo include Foo
  foo extend Foo
end

@straight-shoota straight-shoota added this to the 1.11.0 milestone Dec 7, 2023
@straight-shoota straight-shoota merged commit 4925cad into crystal-lang:master Dec 8, 2023
55 checks passed
@HertzDevil HertzDevil deleted the feature/include-extend-macro-methods branch December 8, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants